-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pg_query fails to build with glibc 2.38 #298
Comments
@loqs Thanks for the report and the patch, tracking this in the core library as pganalyze/libpg_query#202 |
This has been resolved via #299, which was just released as 4.2.3. Thus closing this, but please let us know if there are any more issues & once again thanks for your detailed report! |
gracinet
added a commit
to octobus-net/ruby-pg_query
that referenced
this issue
Sep 8, 2023
pg_query 2.2.1 cannot be compiled with glibc 2.38, because it redefines `strchrnull`, see pganalyze#298 Instead of the patch provided in the above issue, we partially backport the cleaner solution of 4f2eed2. A difference with the 4.2.2 baseline is that the BSDs case was not present in the `pg_config.h` file yet.
gracinet
added a commit
to octobus-net/ruby-pg_query
that referenced
this issue
Sep 8, 2023
pg_query 2.2.1 cannot be compiled with glibc 2.38, because it redefines `strchrnull`, see pganalyze#298 Instead of the patch provided in the above issue, we partially backport the cleaner solution of 4f2eed2. A difference with the 4.2.2 baseline is that the BSDs case was not present in the `pg_config.h` file yet.
gracinet
added a commit
to octobus-net/ruby-pg_query
that referenced
this issue
Sep 8, 2023
pg_query 2.2.1 cannot be compiled with glibc 2.38, because it redefines `strchrnull`, see pganalyze#298 Instead of the patch provided in the above issue, we partially backport the cleaner solution of 4f2eed2. A difference with the 4.2.2 baseline is that the BSDs case was not present in the `pg_config.h` file yet. Decided not to bump the version number, as this is not changing the actual code being run, just some options (chances to get a conflicting 2.2.2 seem to be very low, but one never knows).
13 tasks
egor-khanko
added a commit
to egor-khanko/pg_query
that referenced
this issue
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Versions used:
ruby 3.0.6
google-protobuf 3.23.3
pg_query 4.2.1
glibc 2.38
gcc 13.2.1
Steps to reproduce and output generated:
In glibc 2.38 strchrnul is not restricted to when _GNU_SOURCE is defined 1.
The following patch allowed the build to succeed:
The text was updated successfully, but these errors were encountered: