CTE names are included in tables list

[jcoleman]

Currently the following query:

WITH cte_name AS (
    SELECT 1
)
SELECT *
FROM table_name, cte_name

parses and #tables returns ["cte_name", "table_name"].

I propose either:

1. #tables should return ["table_name"] only, or
2. #tables should remain as is and a new method #cte_names should return the list of CTE aliases

Would you be interested in a PR with one of the above solutions?

[lfittl]

@jcoleman Thats a good question - the intent here was probably to get actual relations (i.e. tables/views), rather than CTEs.

Maybe the best way would be to change the #tables behavior to exclude CTEs, but still add #cte_names in case someone needs that (so you could effectively use q.tables + q.cte_names in case you wanted both).

PR would be very welcome :)

[lfittl]

Actually, if you are feeling motivated on this topic - it might be nice to traverse into nested SELECTs as well, i.e. fix #38

Alternatively I'll do that as a follow-up PR, about time that that issue gets fixed.

[lfittl]

@jcoleman Ended up fixing this in 7eb92cb

Would be great if you could test it and let me know if there's any further improvements you think would help. I'll probably release 0.11.0 in a few days :)

[jcoleman]

That fixes it for me.

Side note: I had to update bundler to 1.12.5 to be able to use the gem by referencing a git ref...apparently there were issues with git ref + native extensions prior to that: rubygems/bundler#4106