Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Union parentheses problem #158

Merged
merged 4 commits into from
Nov 11, 2019
Merged

Conversation

emin100
Copy link
Contributor

@emin100 emin100 commented Nov 5, 2019

If sql include sort clause, must be in paranthesis.

mehmet emin karakas added 2 commits November 5, 2019 13:04
If sql include sort clause, must be in paranthesis.
If sql include sort clause, must be in paranthesis.
@lfittl
Copy link
Member

lfittl commented Nov 11, 2019

@emin100 Same for this - could we add tests here?

add test

SELECT "id", "name" FROM "table1" UNION ( SELECT "id", "name" FROM "table2" ORDER BY "name" ) ORDER BY "id" ASC
@emin100
Copy link
Contributor Author

emin100 commented Nov 11, 2019

Test is added

@lfittl lfittl merged commit ed524a5 into pganalyze:master Nov 11, 2019
@emin100 emin100 deleted the union_parentheses_problem branch December 28, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants