Add support for ORDER/GROUP BY, HAVING, and booleans in WHERE. #53
Conversation
|
@jcoleman Excellent, thanks for thinking of these & the PR. Ready to merge once the rubocop nitpicks are fixed (see Travis). |
jcoleman
force-pushed
the
more-subselect-fixes
branch
from
5ce0265
to
f870ce1
Compare
|
@lfittl Fixed. |
|
@lfittl If we could get a new release soon that'd be great. We vendor our bundle installs and this bug: rubygems/bundler#4106 is making it so we can't use a git ref in our Gemfile. |
|
@jcoleman Sure thing - I have one more change I want to get in, but I'll try to wrap it up today :) |
|
@lfittl Just checking back here again to see if you have any updates. Apologies for bugging you again, but we can't merge in our updated code that relies on this until a new version is pushed. Thanks! |
|
@jcoleman Apologies, I got side-tracked with something else. I've released the current master as 0.11.0 to make your life easier :) Out of curiosity, what are you using pg_query for? |
|
@lfittl Thanks! We're using it in a custom rspec matcher to verify that certain code only accesses certain tables. |
|
@jcoleman Neat, thats actually a great use case I hadn't thought of :) Would be happy to add that to the README as an example of what you can do with the parser, in case its open-source. |
|
It's currently not open source, but I can look into seeing if we might be able to go that route. |
|
@jcoleman Cool, no rush - if you end up releasing it let me know, I could see this being useful to others :) |
No description provided.