Move IAM policy/role creation to after selecting collector platform #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiko713
commented
Apr 5, 2024
| @@ -145,6 +145,7 @@ | |||
|
|
|||
| .navTabs { | |||
| border-bottom: 1px solid #ddd; | |||
| margin-left: 0px !important; | |||
There was a problem hiding this comment.
I just noticed that currently we have a sad margin here:
This is going to help the nav tab to start without having that margin.
keiko713
commented
Apr 5, 2024
| export const IAMRoleCreation = () => { | ||
| const tabs = [ | ||
| [ 'cli', 'CLI' ], | ||
| [ 'console', 'console'], |
There was a problem hiding this comment.
I believe aws is calling the dashboard "console", you can find it in this doc too (it has "console", "AWS CLI", "AWS API"):
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_create.html
I first thought that "console" is not so obvious to talk about the UI dashboard thingy, but I guess it's okay if it's what aws uses?
keiko713
commented
Apr 5, 2024
keiko713
force-pushed
the
create-iam-role-later
branch
from
d1a09db
to
ac7a2dd
Compare
msakrejda
approved these changes
Apr 9, 2024
keiko713
force-pushed
the
create-iam-role-later
branch
from
4391933
to
0f0fde9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current flow, setting up IAM policy/role comes before the collector platform selection.
This PR removes step 3, then add these steps inside of each platform's section after selected. Also, add the "CLI" and "console" option for IAM policy/role creation so that the user can use CLI to do such thing.
It might be better to review this with review app to see how it looks like. When you do so, please go from step 2 of aws section and see if it makes sense:
https://pganalyze-we-new-aws-in-xuapf2.herokuapp.com/docs/install/amazon_rds/02_create_monitoring_user