Skip to content

Commit

Permalink
Remove codecov
Browse files Browse the repository at this point in the history
This has been adding noise to the failures and at this point the
zoneinfo project is stable enough that it's probably not worth it.

In the future if we want to add coverage back in, we can do this:
https://hynek.me/articles/ditch-codecov-python/
  • Loading branch information
pganssle committed Mar 8, 2023
1 parent 882a73f commit b6ce01a
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 44 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/python-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
env:
TOXENV: py
TEST_EXTRAS_TOX: ${{ matrix.tzdata_extras }}
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

steps:
- uses: actions/checkout@v3
Expand All @@ -35,9 +34,6 @@ jobs:
- name: Run tests
run: |
python -m tox
- name: Report coverage
run: |
tox -e coverage-report,codecov
c_coverage:
runs-on: ${{ matrix.os }}
Expand All @@ -61,7 +57,7 @@ jobs:
python -m pip install --upgrade pip 'tox>=3.18'
- name: Run tests
run: |
tox -e gcov,codecov
tox -e gcov
build:
runs-on: "ubuntu-latest"
Expand Down
30 changes: 0 additions & 30 deletions scripts/upload_codecov.py

This file was deleted.

9 changes: 0 additions & 9 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,6 @@ commands =
coverage report
coverage xml

[testenv:codecov]
description = [only run on CI]: upload coverage data to codecov (depends on coverage running first)
deps = codecov==2.1.1
depends = coverage-report
passenv = CODECOV_TOKEN
skip_install = True
commands =
python scripts/upload_codecov.py {toxworkdir}/.coverage

[testenv:format]
description = Run auto formatters
skip_install = True
Expand Down

0 comments on commit b6ce01a

Please sign in to comment.