Specify empty TZ string behavior and add more tests #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
force-pushed
the
tzstr_improvements
branch
2 times, most recently
from
a693371
to
bd922bd
Compare
We will throw an error if we cannot find a TZ string or any ttinfo information; if TZ string is empty or otherwise missing, pick either the last ttinfo that applied or the last ttinfo in the list.
pganssle
force-pushed
the
tzstr_improvements
branch
from
bd922bd
to
54dbfbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Version 2+ files have empty TZ strings, which means that the behavior after the last transition is undefined. For now, we will fall back to "hold the last active value", though "use the last STD value" would also be a reasonable and valid choice. In practice, these may not be terribly different.
This also adds a few more tests to round out both types of invalid TZ string and a few more types of valid TZ string.