Added a parser for SSL Proxy #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxies can now be filtered with an optional parameter in the RequestProxy constructor. For this the parsers have to set the protocol for each proxy object they build. Protocols are stored in the ProxyObject.Protocol enum. PremProxy: parsing was broken because the port number was 'encrypted' and no longer stored in CSS. They are now obtained from a javascript file that holds a function to the key-port pairs.
The default way the program gets user agents is now from an online, up-to-date database with the help of the fake-useragent package. Reading useragents from a custom local file is still available as a parameter to the UserAgentManager class. Solves pgaref#28.
|
Hey @la55u ! To avoid the duplicate commits you should update your master branch which diverged from the original. https://stackoverflow.com/questions/1443210/updating-a-local-repository-with-changes-from-a-github-repository Once you have done that you can port your changes and create a new clean PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a parser + tests for sslproxy provider
p.s.: how do I 'hide' all these previous commits when creating a PR? I mean only the last two are new. thank you, sorry for being noob