Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a KFMon generator #35

Merged
merged 16 commits into from
May 25, 2020
Merged

Implement a KFMon generator #35

merged 16 commits into from
May 25, 2020

Conversation

NiLuJe
Copy link
Collaborator

@NiLuJe NiLuJe commented May 25, 2020

Fix #29

@NiLuJe NiLuJe requested a review from pgaskin as a code owner May 25, 2020 20:09
pgaskin
pgaskin reviewed May 25, 2020
View reviewed changes
src/kfmon.h Show resolved Hide resolved
src/kfmon.c Outdated Show resolved Hide resolved
src/kfmon.c Outdated Show resolved Hide resolved
src/generator_c.c Outdated Show resolved Hide resolved
pgaskin
pgaskin approved these changes May 25, 2020
View reviewed changes
Copy link
Owner

@pgaskin pgaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested on an actual device, but the code looks good.

@pgaskin
Copy link
Owner

pgaskin commented May 25, 2020

@NiLuJe, if you've tested this, I'm ready to merge it.

@NiLuJe
Copy link
Collaborator Author

NiLuJe commented May 25, 2020 •
edited

I'll do a final pass, just in case, before giving you the green light ;).

@NiLuJe
Follow house style for pointer notation
85651b4 
Also to make it consistent even within these files ;p.

(I, err, may have been spoiled by clang-format ^^).
@NiLuJe
Copy link
Collaborator Author

NiLuJe commented May 25, 2020

@geek1011: Yep, good to go! (Unless you'd prefer 85651b4 in a separate PR or not at all?).

@pgaskin pgaskin merged commit ae787f1 into master May 25, 2020
@pgaskin pgaskin deleted the niluje/kfmon-generator branch August 5, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgaskin pgaskin pgaskin approved these changes

Assignees
No one assigned
Labels
feature generator/new generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KFMon generator
2 participants
@NiLuJe @pgaskin