Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task installation failure #5

Open
pgaskin opened this issue Jul 7, 2020 · 5 comments
Open

Task installation failure #5

pgaskin opened this issue Jul 7, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@pgaskin
Copy link
Owner

pgaskin commented Jul 7, 2020

The /install option fails under some circumstances. See just-install/registry#207 (comment).

@pgaskin pgaskin added the bug Something isn't working label Jul 7, 2020
@pgaskin pgaskin self-assigned this Jul 7, 2020
@mimi89999
Copy link

I think it's not the /install failing, but installation of the msi. You said that it only adds a task for the executable and I had this task.

@mimi89999
Copy link

I tested the installer from various commits and it also didn't work. I tested the installer from the commit adding the msi installer and it also doesn't work.

@mimi89999
Copy link

@geek1011 Shouldn't Execute="commit" Impersonate="no" be changed to Execute="deferred" Impersonate="yes"? This works for me.

@mimi89999
Copy link

mimi89999 commented Jul 7, 2020

Also, why aren't you using the startup folder?

@pgaskin
Copy link
Owner Author

pgaskin commented Jul 7, 2020

Thanks for looking into this further.

Also, why aren't you using the startup folder?

It needs to run as admin and show a GUI, but there's nothing like setuid on Windows.

Shouldn't Execute="commit" Impersonate="no" be changed to Execute="deferred" Impersonate="yes"? This works for me.

I'll have to take a closer look at the docs. deferred makes sense, but I'm not convinced about Impersonate.

https://wixtoolset.org/documentation/manual/v3/xsd/wix/customaction.html, Impersonate:

This attribute specifies whether the Windows Installer, which executes as LocalSystem, should impersonate the user context of the installing user when executing this custom action. Typically the value should be 'yes', except when the custom action needs elevated privileges to apply changes to the machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants