'Unify font sizes' patch refinements #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the final result even closer to kepub, if not identical
pgaskin
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #98 and #96
I decided to break out the spreadsheet yesterday to play with some numbers. I discovered that the
scale_factorandDPInumbers of1.0and6.5(the previous patch values) gave a very similar result to using15.0and96.My educated guess (I haven't confirmed the DPI bit) for the kepub formula is thus
( font_size / 15.0 ) * 96.I was able to find equivalent values that can be used in the patch. They are
scale_factor = 2.5and"dpi" = 16.0.Semwise, DNSB and @jackiew1 have all provided positive feedback on the new values over at Mobileread.