Refactor devices, add cover size stuff

[pgaskin]

• A lot more information (codenames, storage, etc)
• Cover sizes
• Cleaner code, easier to extend in the future
• Codenames now match the internal layout (class -> family + optional secondary)
• Based on firmware 4.18.13737

Also see https://gist.github.com/geek1011/613b34c23f026f7c39c50ee32f5e167e and shermp/Kobo-UNCaGED#16

cc @shermp, @NiLuJe, @davidfor

[pgaskin]

TODO:

• Write more tests
• Add more godoc comments
• Update my tools which depend on this
• Test cover generation (work will be in the covergen branch of kepubify)

Also, this is mostly ready for review now.

[shermp]

Have you thought about having a generic "fallback" device, name etc with safe defaults such that new devices can still use the library, even if they aren't supported yet?

Also, this looks awesome. I'm inclined to switch to this library in Kobo-UNCaGED to avoid duplication of code.

[pgaskin]

OK, I've tested the cover generation and some of the device detection as part of pgaskin/kepubify#44, and everything seems to work well.

[shermp]

It's Qt4's QtHash, FWIW ;).

(c.f., https://github.com/NiLuJe/kfmon/blob/f19f8582e7b53d14b7a60cc5b8bc43bac1930b48/kfmon.c#L1096)

Ok, I was wondering how much time @shermp would have spent reversing this... 😃

I'll add a note about that for future reference.

Yeah, I lifted it straight from the Kobo driver in Calibre, which is where I originally saw it.

EDIT: Somewhere in our refactors, that little nugget of info was lost. My original comment was:

// genImagePath generates the directory structure used by
// kobo to store the cover image files.
// It has been ported from the implementation in the KoboTouch
// driver in Calibre
func genImageDirPath(imageID string) string {

[pgaskin]

Unless anyone has more suggestions/objections, I'm planning to merge this after I write tests for the cover stuff.

[pgaskin]

I've released this as v2.

[pgaskin]

@shermp, are you planning on updating KU yourself?

[shermp]

I was thinking of pulling in koboutils as a library and using it instead.

No need to duplicate code/effort :)

[pgaskin]

That was what I meant, but were you planning to implement it?

[shermp]

Yeah. Want to finalize the changes to UNCaGED first before updating KU.

[pgaskin]

Sounds good.

[shermp]

Speaking of UNCaGED, would you be willing to have a look at the open PR at some point? I left it for a while, seeing as you were taking a break from Kobo stuff.

[pgaskin]

Yep, will do today or tomorrow. I'll be taking another break afterwards until the next firmware release.

[shermp]

Thanks