Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert builtin errors to EvalErrors #3

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

pgavlin
Copy link
Owner

@pgavlin pgavlin commented Apr 4, 2024

This allows us to capture a stacktrace with the error so that failures
indicate the line of the failing expression.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 44.55%. Comparing base (73cf44e) to head (97795ae).

Files Patch % Lines
cmd/dawn/builtins.go 0.00% 5 Missing ⚠️
cmd/dawn/events.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   45.32%   44.55%   -0.77%     
==========================================
  Files          23       23              
  Lines        2716     2765      +49     
==========================================
+ Hits         1231     1232       +1     
- Misses       1348     1395      +47     
- Partials      137      138       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This allows us to capture a stacktrace with the error so that failures
indicate the line of the failing expression.
@pgavlin pgavlin changed the title Convert builtin errors to EvalError Convert builtin errors to EvalErrors Apr 4, 2024
@pgavlin pgavlin merged commit 2dd5e6b into main Apr 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants