Update missing flag in storage/posix test.

The storageNewItrP() permissions test was running twice with the errorOnMissing flag set to false. Fix by setting to true for one test. Also update the comments to be clearer about what the tests are doing and fix minor formatting.
pgbackrest · Dec 7, 2022 · 1345caa · 1345caa · jreidthompson · Dec 8, 2022
1 parent 81d84ab
commit 1345caa
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/test/src/module/storage/posixTest.c b/test/src/module/storage/posixTest.c
@@ -356,9 +356,12 @@ testRun(void)
         TEST_RESULT_PTR(storageNewItrP(storageTest, STRDEF(BOGUS_STR), .nullOnMissing = true), NULL, "ignore missing dir");
 
 #ifdef TEST_CONTAINER_REQUIRED
+        // -------------------------------------------------------------------------------------------------------------------------
+        TEST_TITLE("error on permission denied, regardless of errorOnMissing setting");
+
         TEST_ERROR_FMT(
-            storageNewItrP(storageTest, pathNoPerm), PathOpenError, STORAGE_ERROR_LIST_INFO ": [13] Permission denied",
-            strZ(pathNoPerm));
+            storageNewItrP(storageTest, pathNoPerm, .errorOnMissing = true), PathOpenError,
+            STORAGE_ERROR_LIST_INFO ": [13] Permission denied", strZ(pathNoPerm));
 
         // Should still error even when ignore missing
         TEST_ERROR_FMT(
@@ -516,16 +519,16 @@ testRun(void)
 
 #ifdef TEST_CONTAINER_REQUIRED
         // -------------------------------------------------------------------------------------------------------------------------
-        TEST_TITLE("error on missing, regardless of errorOnMissing setting");
+        TEST_TITLE("error on permission denied, regardless of errorOnMissing setting");
 
         TEST_ERROR_FMT(
             storageListP(storageTest, pathNoPerm, .errorOnMissing = true), PathOpenError,
             STORAGE_ERROR_LIST_INFO ": [13] Permission denied", strZ(pathNoPerm));
 
         // Should still error even when ignore missing
         TEST_ERROR_FMT(
-            storageListP(storageTest, pathNoPerm), PathOpenError,
-            STORAGE_ERROR_LIST_INFO ": [13] Permission denied", strZ(pathNoPerm));
+            storageListP(storageTest, pathNoPerm), PathOpenError, STORAGE_ERROR_LIST_INFO ": [13] Permission denied",
+            strZ(pathNoPerm));
 #endif // TEST_CONTAINER_REQUIRED
 
         // -------------------------------------------------------------------------------------------------------------------------