Skip to content

Commit

Permalink
Remove mock integration tests.
Browse files Browse the repository at this point in the history
These tests have not been maintained for several years, i.e. no tests for new features have been added. They are highly duplicative of the unit tests but do have the advantage of mixing in different storage drivers. They were allowed to remain because they were not doing any harm even if they were probably not doing any good.

However, the real integration tests (that run directly against PostgreSQL) also test storage drivers and have been updated with new features over time. The real integration tests are now being migrated to C and as part of that effort the mock integration tests need to be removed or migrated, and they do not provide enough value to migrate.

Remove all mock integration tests and a leftover Perl performance test.
  • Loading branch information
dwsteele committed Feb 16, 2024
1 parent 6835178 commit d41b21c
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 2,209 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Expand Up @@ -358,7 +358,7 @@ pgbackrest/test/test.pl --vm-build --vm=u20
pgbackrest-dev => Run a Specific Test Run
```
pgbackrest/test/test.pl --vm=u20 --module=mock --test=archive --run=2
pgbackrest/test/test.pl --vm=u20 --module=postgres --test=interface --run=2

--- output ---

Expand Down
2 changes: 1 addition & 1 deletion doc/xml/contributing.xml
Expand Up @@ -398,7 +398,7 @@ pgbackrest/doc/doc.pl --help
<title>Run a Specific Test Run</title>

<execute output="y">
<exe-cmd>pgbackrest/test/test.pl {[dash]}-vm=u20 {[dash]}-module=mock {[dash]}-test=archive {[dash]}-run=2</exe-cmd>
<exe-cmd>pgbackrest/test/test.pl {[dash]}-vm=u20 {[dash]}-module=postgres {[dash]}-test=interface {[dash]}-run=2</exe-cmd>
<exe-cmd-extra>{[test-cmd-extra]}</exe-cmd-extra>
</execute>
</execute-list>
Expand Down
29 changes: 0 additions & 29 deletions test/define.yaml
Expand Up @@ -1003,30 +1003,6 @@ unit:
# **********************************************************************************************************************************
integration:

# ********************************************************************************************************************************
- name: mock

test:
# ----------------------------------------------------------------------------------------------------------------------------
- name: stanza
total: 2

# ----------------------------------------------------------------------------------------------------------------------------
- name: expire
total: 2

# ----------------------------------------------------------------------------------------------------------------------------
- name: archive
total: 2

# ----------------------------------------------------------------------------------------------------------------------------
- name: archive-stop
total: 2

# ----------------------------------------------------------------------------------------------------------------------------
- name: all
total: 2

# ********************************************************************************************************************************
- name: real
db: true
Expand All @@ -1048,11 +1024,6 @@ performance:
- name: performance

test:
# ----------------------------------------------------------------------------------------------------------------------------
- name: archive-perl
total: 1
binReq: true

# ----------------------------------------------------------------------------------------------------------------------------
- name: type
total: 6
Expand Down

0 comments on commit d41b21c

Please sign in to comment.