Repository navigation
Improve security of OpenSSL settings - #948
Merged
Merged
Conversation
eulerto
approved these changes
Sep 22, 2023
eulerto
left a comment
eulerto
left a comment
Member
There was a problem hiding this comment.
You forgot to change etc/pgbouncer.ini. Other than that, LGTM.
The default OpenSSL ciphers were extremely outdated. This PR brings them up to date. The main code changes for this are in libusual (which this PR updates): libusual/libusual#40 The changes in PgBouncer itself are mostly doc changes. The only code change is changing the default of the cipher to actually be "default", which now means the same as "fast" anyway.
JelteF
force-pushed
the
update-libusual
branch
from
September 22, 2023 07:37
64c1b78 to
5c079d9
Compare
JelteF
added a commit
to JelteF/pgbouncer
that referenced
this pull request
Sep 22, 2023
I forgot to address the review comment mentioning this when I fixed the failing tests.
JelteF
added a commit
that referenced
this pull request
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default OpenSSL ciphers were extremely outdated. This PR brings them
up to date. The main code changes for this are in libusual (which this
PR updates):
libusual/libusual#40
The changes in PgBouncer itself are mostly doc changes. The only code
change is changing the default of the cipher to actually be "default",
which now means the same as "fast" anyway.