fix: Mark PgTupleDesk::from_pg_copy unsafe (#224)

Signed-off-by: Ana Hobden <operator@hoverbear.org>
pgcentralfoundation · Sep 24, 2021 · c6d699f · c6d699f
1 parent 1a717ae
commit c6d699f
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/pgx/src/tupdesc.rs b/pgx/src/tupdesc.rs
@@ -70,10 +70,15 @@ impl<'a> PgTupleDesc<'a> {
     /// allocated in the `CurrentMemoryContext`
     ///
     /// When this instance is dropped, the copied TupleDesc is `pfree()`'d
-    pub fn from_pg_copy<'b>(ptr: pg_sys::TupleDesc) -> PgTupleDesc<'b> {
+    ///
+    /// ## Safety
+    ///
+    /// This method is unsafe as we cannot validate that the provided `pg_sys::TupleDesc` is valid
+    /// or requires reference counting.
+    pub unsafe fn from_pg_copy<'b>(ptr: pg_sys::TupleDesc) -> PgTupleDesc<'b> {
         PgTupleDesc {
             // SAFETY:  pg_sys::CreateTupleDescCopyConstr will be returning a valid pointer
-            tupdesc: unsafe { PgBox::from_pg(pg_sys::CreateTupleDescCopyConstr(ptr)) },
+            tupdesc: PgBox::from_pg(pg_sys::CreateTupleDescCopyConstr(ptr)),
             parent: None,
             data: None,
             need_release: false,