Use SPITupleTable->numvals when available #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from PostgreSQL, SPI tuple table contains number of rows returned in `numvals`, with `SPI_processed` still available for "historical reasons": "The fields tupdesc, vals, and numvals can be used by SPI callers; the remaining fields are internal. vals is an array of pointers to rows. The number of rows is given by numvals (for somewhat historical reasons, this count is also returned in SPI_processed)." (https://www.postgresql.org/docs/current/spi-spi-execute.html) Also: "Some utility commands (COPY, CREATE TABLE AS) don't return a row set, so SPI_tuptable is NULL, but they still return the number of rows processed in SPI_processed." So we're following this logic. This is to ensure we're not relying on "historical" API going forward.
eeeebbbbrrrr
requested changes
Feb 8, 2023
|
I fixed it but remember we like PRs against |
Sorry about that! My colds-induced brain fog is still here. |
|
I'm re-running CI for this. Don't remember why it failed, and the logs have rolled off. haha. Once CI goes green I'll merge. This is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from PostgreSQL, SPI tuple table contains number of rows returned in
numvals, withSPI_processedstill available for "historical reasons":"The fields tupdesc, vals, and numvals can be used by SPI callers; the remaining fields are internal. vals is an array of pointers to rows. The number of rows is given by numvals (for somewhat historical reasons, this count is also returned in SPI_processed)."
(https://www.postgresql.org/docs/current/spi-spi-execute.html)
Also:
"Some utility commands (COPY, CREATE TABLE AS) don't return a row set, so SPI_tuptable is NULL, but they still return the number of rows processed in SPI_processed."
So we're following this logic.
This is to ensure we're not relying on "historical" API going forward.