Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize bindgen arg sets in fn (nfc) #1312

Conversation

workingjubilee
Copy link
Member

No functional changes.

Copy link
Contributor

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this is an improvement honestly. Why is it a trait?

@workingjubilee
Copy link
Member Author

I'm not sure that this is an improvement honestly. Why is it a trait?

for mostly-preserving the existing method call syntax, thassit. happy to make them free fn.

@thomcc
Copy link
Contributor

thomcc commented Sep 28, 2023

I'd prefer free functions, since then adding parameters and such doesn't require modifying as many places.

@workingjubilee
Copy link
Member Author

sounds good to me!

@thomcc
Copy link
Contributor

thomcc commented Sep 28, 2023

We talked about this on discord and I don't really care about this enough to object to it becoming a trait if that's a change @workingjubilee wants to make.

@workingjubilee
Copy link
Member Author

workingjubilee commented Sep 28, 2023

Free fn are fine. We discussed some options for improving things further and like... mostly, I'm okay with anything as long as it's somewhat more organized than "not at all". The main goal is to avoid this becoming impossible to read and sift through when more bindgen flags get added.

@workingjubilee workingjubilee changed the title Organize bindgen args in a trait (nfc) Organize bindgen arg sets in fn (nfc) Sep 28, 2023
@workingjubilee workingjubilee merged commit 4a7f535 into pgcentralfoundation:develop Sep 28, 2023
9 checks passed
@workingjubilee workingjubilee deleted the abstract-bindgen-args branch September 29, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants