Set locale to C.UTF-8 when creating database clusters #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomcc Do you think this handling of the locale setting is correct for Mac? |
Note that testing this requires: - reinstalling cargo-pgx - deleting `~/.pgx` - rerunning `cargo pgx init` to get a new database cluster - cleaning the target directory of any repos you want to test this on
Sorry, I didn't see this. Yes, it looks correct (assuming that those arguments to initdb work as I'd expect). |
eeeebbbbrrrr
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #691 by setting the locale to
C.UTF-8when creating databases.On macOS the
C.UTF-8locale doesn't exist so the locale is set toCand theCTYPEtoUTF-8, which has the same effect as setting the locale toC.UTF-8on other operating systems.Note that testing this requires creating a new database cluster. I tested this by:
~/.pgxcargo pgx initto get a new database cluster