Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidekiq 4 support #2

Merged
merged 2 commits into from
Feb 7, 2016
Merged

Sidekiq 4 support #2

merged 2 commits into from
Feb 7, 2016

Conversation

bbozo
Copy link
Contributor

@bbozo bbozo commented Feb 5, 2016

Resolves #1

@pgeraghty
Copy link
Owner

Thanks for the contribution. I'm going to pull this in and then attempt to remedy the sporadic Travis failures (rubygems/bundler#3558 (comment)).

@pgeraghty pgeraghty closed this Feb 7, 2016
@pgeraghty pgeraghty reopened this Feb 7, 2016
pgeraghty added a commit that referenced this pull request Feb 7, 2016
@pgeraghty
Merge pull request #2 from TapeRecorder/upgrade_to_sidekiq_4
f6a859a 
Sidekiq 4 support
@pgeraghty pgeraghty merged commit f6a859a into pgeraghty:master Feb 7, 2016
@bbozo
Copy link
Contributor Author

bbozo commented Feb 7, 2016

uninitialized constant AbstractController::Rendering::ActionController is due to rails/rails#23242 :)

@pgeraghty
Copy link
Owner

Yep, well-spotted - I didn't scroll far enough to grasp what you meant until I encountered it. Thanks for the heads up. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbozo @pgeraghty