Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enum type #1

Closed
wants to merge 1 commit into from
Closed

add enum type #1

wants to merge 1 commit into from

Conversation

sbutz
Copy link

@sbutz sbutz commented Dec 7, 2020

No description provided.

@hmenke
Copy link
Member

hmenke commented Dec 7, 2020

Please add documentation.

Comment on lines 114 to 124
\newenvironment{enumeration}[3][]%
{
\begin{classAndInterfaceCommon}{#1}{#2}{#3}
}%
{\calcuateNumberOfParts{}
\node[this umlcd style, anchor=north] (\umlcdClassName) at (\umlcdClassPos)
{$<<$enumeration$>>$ \\ \textbf{\umlcdClassName}
\insertAttributesAndOperations{}
};

\end{classAndInterfaceCommon}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of potential spurious spaces and the indentation (or rather the lack thereof) is suboptimal.

Suggested change
\newenvironment{enumeration}[3][]%
{
\begin{classAndInterfaceCommon}{#1}{#2}{#3}
}%
{\calcuateNumberOfParts{}
\node[this umlcd style, anchor=north] (\umlcdClassName) at (\umlcdClassPos)
{$<<$enumeration$>>$ \\ \textbf{\umlcdClassName}
\insertAttributesAndOperations{}
};
\end{classAndInterfaceCommon}
}
\newenvironment{enumeration}[3][]%
{%
\begin{classAndInterfaceCommon}{#1}{#2}{#3}%
}%
{%
\calcuateNumberOfParts{}%
\node[this umlcd style, anchor=north] (\umlcdClassName) at (\umlcdClassPos)
{$<<$enumeration$>>$\\ \textbf{\umlcdClassName}\insertAttributesAndOperations{}};%
\end{classAndInterfaceCommon}%
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants