Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMTX incompatbility: don't use fixed strings for \meaning #1193

Closed
leahneukirchen opened this issue Sep 23, 2022 · 2 comments
Closed

LMTX incompatbility: don't use fixed strings for \meaning #1193

leahneukirchen opened this issue Sep 23, 2022 · 2 comments

Comments

@leahneukirchen
Copy link
Contributor

Brief outline of the bug

Some TikZ libraries (e.g. quotes) use keys which include the string given by \meaning, e.g.

\pgfkeyssetvalue{/handlers/first char syntax/the character "}{\tikz@quote@parser}%

However, in LMTX, \meaning" expands to

the character U+0022 'quotation mark'

and they don't intent to change that.

In my experiments, it seems sufficient to instead write

\pgfkeyssetvalue{/handlers/first char syntax/\meaning"}{\tikz@quote@parser}%

which uses whatever string the current TeX implementation uses.

This is related to #990.

Minimal working example (MWE)

(this is ConTeXt)

\usemodule[tikz]
\usetikzlibrary[quotes,angles]

\starttext

\meaning"

\starttikzpicture
  \node ["abc" draw] {node};
\stoptikzpicture

\stoptext
@hmenke hmenke closed this as completed in 0280303 Sep 23, 2022
@hmenke
Copy link
Member

hmenke commented Sep 23, 2022

I think we need \expandafter\meaning\string" here, just in case " is active at that point.

@leahneukirchen
Copy link
Contributor Author

Also in

\expandafter\let\csname tikz@anim@test@the character 0\endcsname\pgfutil@empty

Thanks for the quick fixing!

loopspace pushed a commit to loopspace/pgf that referenced this issue Apr 2, 2024
Fixes pgf-tikz#1193

Co-authored-by: Leah Neukirchen <leah@vuxu.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants