Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parser] Error when parameter character is parsed #715

Closed
Skillmon opened this issue Jul 22, 2019 · 2 comments

Comments

@Skillmon
Copy link
Contributor

commented Jul 22, 2019

In the parser module, parsing a character with category code 6 will throw an error Illegal parameter number in definition of \pgfparserletter.

Example code:

\documentclass[]{article}

\usepackage{pgf}
\usepgfmodule{parser}
\pgfparserdef{error}{initial}|{\pgfparserswitch{final}}
\pgfparserdef{error}{initial}{\meaning##}{category 6 read}
\pgfparserset{status=true}

\begin{document}
\pgfparserparse{error}#|
\end{document}
@Skillmon

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

I already know how to fix this, but first wanted to ask whether fixing it only for # with category 6 is ok, or should I implement a more robust but slower code that should work for any character of category 6?

@hmenke

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

Since you are probably the only user of the parser module at all, you can fix it at your discretion.

Skillmon added a commit to Skillmon/pgf that referenced this issue Jul 23, 2019

@Skillmon Skillmon referenced this issue Jul 23, 2019

Merged

fixes #715 #716

@hmenke hmenke closed this in #716 Jul 30, 2019

hmenke added a commit to hmenke/pgf that referenced this issue Aug 3, 2019

hmenke added a commit to hmenke/pgf that referenced this issue Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.