Use Black for Consistent Formatting and Deprecate isort/yapf/flake8 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for using black in the place of yapf, flake8, isort. This includes CI/CD, documentation, and our pip environment. Next steps will be to blacken the code itself (I want a separate commit as that will be a big diff).
|
The scraping step of our CI run timed out because the Allegheny County Authority for Improvements in Municipalities (AIM) website is not responding. The base domain has changed from I believe it should be safe to merge #145 once we fix the boto3 dependency issue. Once #145 is merged we will want to reach out to anyone with works in progress so that they can transition to black. |
ben-nathanson
force-pushed
the
blacken
branch
4 times, most recently
from
8651686
to
425c9e2
Compare
ben-nathanson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements Black as our one-stop linter and removes isort/yapf/flake8. These are all great linting tools for different use cases but using Black here will help new contributors focus on writing code rather than formatting code.