Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in Mocha v6 due to undefined options #138

Closed
wants to merge 1 commit into from

Conversation

almirfilho
Copy link

Passing undefined options to mocha v6 cause it to break.
This PR just prevent passing the options object like this:

{ 
  reporter: 'nyan',
  require: '@babel/register',
  grep: undefined,
  ui: undefined,
  timeout: undefined,
  invert: undefined,
  ignoreLeaks: undefined,
  growl: undefined,
  globals: undefined,
  colors: undefined,
  slow: undefined
}

And instead pass it like this:

{ 
  reporter: 'nyan',
  require: '@babel/register'
}

Tests passing. No side effects.
Thank you for this package!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8cdb5ae on almirfilho:master into 185d515 on pghalliday:master.

@almirfilho
Copy link
Author

@pghalliday could you please merge this and bump a version? Thanks!

@bonesoul
Copy link

+1

@almirfilho
Copy link
Author

This is no longer an issue since mocha version 6.1.0. Closing this PR.

@almirfilho almirfilho closed this May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants