Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Incorporate file revision hash #10

Closed
andrewboni opened this issue May 21, 2014 · 5 comments
Closed

Feature request: Incorporate file revision hash #10

andrewboni opened this issue May 21, 2014 · 5 comments

Comments

@andrewboni
Copy link

grunt-usemin is nice in that it not only concats and minfies JS/CSS, but also prepends a file hash for cache-busting purposes. Would be nice if this plugin had the same functionality.

I see that there's grunt-jade-filerev-usemin, but it seems like that should be merged into this plugin.

Thoughts?
@pgilad
Copy link
Owner

pgilad commented May 21, 2014

First off, great idea. This can be easily expanded with adding the plugin grunt-filerev.
In fact, I'm thinking that plugin functionality such as this, which is more than the basic concat-uglify-cssmin should be user-configurable. For instance if someone wants to run grunt-autoprefixer on css files he should be able to do so with ease.

I'll take a look at it when I have time... Thanks for the idea!

@andrewboni
Copy link
Author

Great- thanks!

@pgilad
Copy link
Owner

pgilad commented May 21, 2014

@noos what do you think?

pgilad added a commit that referenced this issue May 22, 2014
@pgilad
Working on external tasks abstraction
a4c6a2b 
See #10
pgilad added a commit that referenced this issue May 22, 2014
@pgilad
setup for task abstraction. #10
d518648
pgilad added a commit that referenced this issue May 24, 2014
@pgilad
Introduce task abstraction - choose tasks to run
c6d73b8 
Relevant for #10
pgilad added a commit that referenced this issue May 24, 2014
@pgilad
Still work todo on abstraction of tasks. Tests bad
fa11f89 
Working on #10, still not ok
pgilad added a commit that referenced this issue May 24, 2014
@pgilad
All tests are passing in new api, see #10
f2a57fb
pgilad added a commit that referenced this issue May 24, 2014
@pgilad
Extract functions from main file.
71cae53 
See #10
pgilad added a commit that referenced this issue May 24, 2014
@pgilad
Add option to specify tasks that output to dir
787d817 
See #10.

For example: filerev needs dest as a directory
This will require fixing the output of the optimized jade file
pgilad added a commit that referenced this issue May 24, 2014
@pgilad
#10 - filerev works without optimized jade
2e133a3
@pgilad pgilad closed this as completed in 6efeab2 May 24, 2014
@pgilad
Copy link
Owner

pgilad commented May 24, 2014

done. checkout the new options in readme @andrewboni

@noos
Copy link

noos commented May 24, 2014

@pgilad nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewboni @noos @pgilad