Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send client-encoding in startup packet not SET #165

Closed
ringerc opened this issue Jul 1, 2014 · 3 comments
Closed

Send client-encoding in startup packet not SET #165

ringerc opened this issue Jul 1, 2014 · 3 comments
Assignees
Labels

Comments

@ringerc
Copy link
Member

ringerc commented Jul 1, 2014

It looks like we may have an issue with client-encoding and pre-auth errors. Per:

http://stackoverflow.com/q/24496757/398670

I'll look into this when time permits, just noting it here for now.

@ringerc ringerc self-assigned this Jul 1, 2014
@ringerc ringerc added the bug label Jul 1, 2014
@davecramer
Copy link
Member

From what I can see the encoding is set before the auth

https://github.com/pgjdbc/pgjdbc/blob/master/org/postgresql/core/v3/ConnectionFactoryImpl.java#L170

@lufte
Copy link

lufte commented Jul 1, 2014

Hi. Having @ringerc 's answer in the stackoverflow question I did a little test and he seems to be right.

  1. Try to connect with wrong password and you get the message: FATAL: la autentificaci��n password fall�� para el usuario ��postgres��.
  2. Connect with correct password, send the query "SELECT 1/0" and you get the message: "ERROR: división por cero". Note the "ó" character now correctly encoded.

@davecramer
Copy link
Member

Hmmm strange as we do set the encoding before the authentication. Unless
this is a backend problem

Dave Cramer

On 1 July 2014 17:29, Javier Ayres notifications@github.com wrote:

Hi. Having @ringerc https://github.com/ringerc 's answer in the
stackoverflow question I did a little test and he seems to be right.

  1. Try to connect with wrong password and you get the message: FATAL: la
    autentificaci��n password fall�� para el usuario ��postgres��.
  2. Connect with correct password, send the query "SELECT 1/0" and you get
    the message: "ERROR: división por cero". Note the "ó" character now
    correctly encoded.


Reply to this email directly or view it on GitHub
#165 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants