In multiThread Case , the statement will Loop forever

[zhangyongtaocn]

I'm submitting a bug report

Driver Version 4.2.14

Java Version jdk1.8

OS Version windows

PostgreSQL Version 12.2.3

To Reproduce
I use dbtransfer( https://github.com/evolute-pt/dbtransfer ) to copy Sql server database to PostSql
total 20 tables . but dbtransfer cannot stop,still running .
I debug the jdbc driver and fount the program run in Pgstatmement.java line 1004 -1008 ,loop forever .
I found this.statementState == StatementCancelState.IDLE
but the while block check if this.statementState == StatementCancelState.CANCELLED
so this loop cannot break .
I add code like
if(this.statementState == StatementCancelState.IDLE) //// ---- update 20200613
break;
then Program running OK

[davecramer]

Is this

pgjdbc/pgjdbc/src/main/java/org/postgresql/jdbc/PgStatement.java

Lines 1003 to 1018 in 13a644b

	while (!STATE_UPDATER.compareAndSet(this, StatementCancelState.CANCELLED, StatementCancelState.IDLE)) {
	try {
	// Note: wait timeout here is irrelevant since synchronized(connection) would block until
	// .cancel finishes
	connection.wait(10);
	} catch (InterruptedException e) { // NOSONAR
	// Either re-interrupt this method or rethrow the "InterruptedException"
	interrupted = true;
	}
	}
	}
	if (interrupted) {
	Thread.currentThread().interrupt();
	}
	}

the code you are referring to?

[zhangyongtaocn]

Yes, I add code after connection.wait(10);

[davecramer]

Interesting, can you send a PR please