-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Japanese translation #1275
Fix Japanese translation #1275
Conversation
@horiguti , thanks for the quick update. I've rebased your branch on top of current master, could you please recheck if it still looks good? PS. @davecramer , we might need to review headers for |
msgid "Unsupported type conversion to {1}." | ||
msgstr "サポートされないバイナリエンコーディングです: {0}." | ||
msgstr "{1} への型変換はサポートされていません。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we have off-by-one errors like
throw new PSQLException(GT.tr("Unsupported type conversion to {1}.", type), |
Arguments are 0-indexed, so it should be {0}
.
I think we can handle those issues later (and update po files accordingly)
Codecov Report
@@ Coverage Diff @@
## master #1275 +/- ##
=========================================
Coverage ? 68.76%
Complexity ? 3855
=========================================
Files ? 174
Lines ? 16029
Branches ? 2612
=========================================
Hits ? 11023
Misses ? 3775
Partials ? 1231 |
(I'm not falimiar to this interface so replying here at once) Sorry for the careless change of permission bits. (It's due to samba's setting). @vlsi> I've rebased your branch on top of current master, could you please recheck if it still looks good? I reviewed rebased file and found one difference at line 1608 (tried to call end..) which just changes line splitting position. In short, it looks still fine. Thanks. |
Yeah, that is one more "feature" of gettext that we cannot influence (there's I'll add a script to pgjdbc that would join multiline strings to a single line. |
These are assorted patchs to fix Japanese translation on the master branch in response to a call by Dave Cramer in pgsql-translators . Plus additional cleanups of the whole Japanese translation.
This consists of the following fixes.
And to put these changes on top of, 762cd4e (1st) is ja.po update made by mvn -Ptranslate compile.
regards.