fix parent version in pgjdbc/pom.xml as well #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorsol
reviewed
Jul 2, 2019
.travis/travis_build.sh
Outdated
| @@ -8,6 +8,13 @@ then | |||
| python -c 'import os,sys,fcntl; flags = fcntl.fcntl(sys.stdout, fcntl.F_GETFL); fcntl.fcntl(sys.stdout, fcntl.F_SETFL, flags&~os.O_NONBLOCK);' | |||
| export PROJECT_VERSION=$(mvn -B -N org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep -v '\[') | |||
| export PARENT_VERSION=$(mvn -B -N org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.parent.version | grep -v '\[') | |||
| export CHECK_PARENT_VERSION=$( | |||
There was a problem hiding this comment.
Simpler approach:
export CHECK_PARENT_VERSION=$(mvn help:evaluate -Dexpression=project.parent.version -q -DforceStdout -f pgjdbc/pom.xml)
|
✅ Build pgjdbc 1.0.330 completed (commit e30590e7c9 by @praiskup) |
This should fix Travis build for FEDORA_CI.
praiskup
force-pushed
the
fix-travis-fedora-cie
branch
from
2c930b6
to
3060b96
Compare
|
@jorsol, thanks, that seems to work as well! Fixed. |
|
✅ Build pgjdbc 1.0.331 completed (commit eaef7a49e4 by @praiskup) |
Codecov Report
@@ Coverage Diff @@
## master #1522 +/- ##
============================================
+ Coverage 68.77% 68.85% +0.07%
- Complexity 3930 3938 +8
============================================
Files 179 179
Lines 16467 16467
Branches 2674 2674
============================================
+ Hits 11325 11338 +13
+ Misses 3893 3885 -8
+ Partials 1249 1244 -5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix Travis build for FEDORA_CI.