Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Preparing for upcoming Checkstyle release 8.28 #1654

Merged
merged 1 commit into from Dec 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions pgjdbc/src/main/checkstyle/checks.xml
Expand Up @@ -165,10 +165,11 @@
<module name="OverloadMethodsDeclarationOrder"/>
<module name="VariableDeclarationUsageDistance"/>-->
<module name="CustomImportOrder">
<property name="specialImportsRegExp" value="org.postgresql"/>
<property name="standardPackageRegExp" value="^java\."/>
<property name="specialImportsRegExp" value="^javax\."/>
<property name="sortImportsInGroupAlphabetically" value="true"/>
<property name="customImportOrderRules"
value="STATIC###SPECIAL_IMPORTS###THIRD_PARTY_PACKAGE###STANDARD_JAVA_PACKAGE"/>
value="STATIC###SAME_PACKAGE(2)###THIRD_PARTY_PACKAGE###STANDARD_JAVA_PACKAGE###SPECIAL_IMPORTS"/>
</module>

<!-- Import should be explicit, and only from pure java packages.
Expand Down
1 change: 0 additions & 1 deletion pgjdbc/src/main/java/org/postgresql/PGConnection.java
Expand Up @@ -16,7 +16,6 @@
import java.sql.Array;
import java.sql.SQLException;
import java.sql.Statement;

import java.util.Map;

/**
Expand Down
1 change: 1 addition & 0 deletions pgjdbc/src/main/java/org/postgresql/core/PGStream.java
Expand Up @@ -23,6 +23,7 @@
import java.net.Socket;
import java.net.SocketTimeoutException;
import java.sql.SQLException;

import javax.net.SocketFactory;

/**
Expand Down
Expand Up @@ -43,6 +43,7 @@
import java.util.logging.Level;
import java.util.logging.LogRecord;
import java.util.logging.Logger;

import javax.net.SocketFactory;

/**
Expand Down
Expand Up @@ -26,7 +26,6 @@
import java.sql.Types;
import java.util.ArrayList;
import java.util.Arrays;

import java.util.Collections;
import java.util.Comparator;
import java.util.HashMap;
Expand Down
Expand Up @@ -6,6 +6,7 @@
package org.postgresql.ssl;

import java.util.Properties;

import javax.net.ssl.SSLSocketFactory;

/**
Expand Down
1 change: 1 addition & 0 deletions pgjdbc/src/main/java/org/postgresql/ssl/LibPQFactory.java
Expand Up @@ -25,6 +25,7 @@
import java.security.cert.Certificate;
import java.security.cert.CertificateFactory;
import java.util.Properties;

import javax.net.ssl.KeyManager;
import javax.net.ssl.SSLContext;
import javax.net.ssl.TrustManager;
Expand Down
1 change: 1 addition & 0 deletions pgjdbc/src/main/java/org/postgresql/ssl/MakeSSL.java
Expand Up @@ -18,6 +18,7 @@
import java.util.Properties;
import java.util.logging.Level;
import java.util.logging.Logger;

import javax.net.ssl.HostnameVerifier;
import javax.net.ssl.SSLSocket;
import javax.net.ssl.SSLSocketFactory;
Expand Down
Expand Up @@ -17,6 +17,7 @@
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;

import javax.naming.InvalidNameException;
import javax.naming.ldap.LdapName;
import javax.naming.ldap.Rdn;
Expand Down
Expand Up @@ -11,6 +11,7 @@

import java.net.IDN;
import java.util.Properties;

import javax.net.ssl.HostnameVerifier;
import javax.net.ssl.SSLSession;

Expand Down
Expand Up @@ -20,7 +20,6 @@
package org.postgresql.util;

import java.io.Writer;

import java.util.logging.ErrorManager;
import java.util.logging.Formatter;
import java.util.logging.Handler;
Expand Down
Expand Up @@ -10,7 +10,6 @@
import org.postgresql.test.TestUtil;

import org.hamcrest.core.StringStartsWith;

import org.junit.Assert;
import org.junit.Test;

Expand Down
Expand Up @@ -12,6 +12,7 @@
import org.junit.Test;

import java.io.IOException;

import javax.naming.NamingException;

/**
Expand Down
Expand Up @@ -9,7 +9,6 @@
import static org.junit.Assert.assertTrue;

import org.postgresql.core.ServerVersion;

import org.postgresql.test.TestUtil;
import org.postgresql.test.jdbc2.BaseTest4;

Expand Down
Expand Up @@ -15,7 +15,6 @@
import org.postgresql.test.jdbc2.BaseTest4;

import org.junit.Test;

import org.w3c.dom.Node;

import java.io.IOException;
Expand Down
1 change: 1 addition & 0 deletions pgjdbc/src/test/java/org/postgresql/test/ssl/SslTest.java
Expand Up @@ -27,6 +27,7 @@
import java.util.Collections;
import java.util.List;
import java.util.Properties;

import javax.net.ssl.SSLHandshakeException;

@RunWith(Parameterized.class)
Expand Down