Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue PgDatabaseMetaData.getFunctions() #1774

Merged
merged 3 commits into from May 8, 2020

Conversation

kili668
Copy link
Contributor

@kili668 kili668 commented May 7, 2020

Fix issue (#1771) to return only functions in PgDatabaseMetaData.getFunctions()

  • This is a breaking change
  • Locally tested with Version 10.12 and 12.2

@kili668 kili668 changed the title Fix issue #1771 Fix issue PgDatabaseMetaData.getFunctions() May 7, 2020
@codecov-io
Copy link

@codecov-io codecov-io commented May 7, 2020

Codecov Report

Merging #1774 into master will increase coverage by 0.02%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #1774      +/-   ##
============================================
+ Coverage     69.24%   69.27%   +0.02%     
- Complexity     4182     4184       +2     
============================================
  Files           187      187              
  Lines         17239    17241       +2     
  Branches       2855     2856       +1     
============================================
+ Hits          11938    11943       +5     
+ Misses         4015     4013       -2     
+ Partials       1286     1285       -1     

@davecramer
Copy link
Member

@davecramer davecramer commented May 7, 2020

Can you add some tests and note this is a breaking change.

@davecramer davecramer merged commit 0eb5eea into pgjdbc:master May 8, 2020
4 checks passed
@kili668 kili668 deleted the issue-1771 branch May 15, 2020
davecramer pushed a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
* Fix pgjdbc#1771

Only return functions and not procedures for servers v11 and up.

Co-authored-by: kfe <kfe@kili668>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants