misc: Add separate class to hold QueryExecutor.execute(...) options

[sehrope]

Adds new internal ExecuteOptions and ExecuteManyOptions classes to hold all options for QueryExecutor.execute(...) so that future additions of new parameters can be more easily defaulted in a single location rather than modifying all call sites.

Also adds some legibility for repeated parameters of the same data type as things like maxRows, fetchSize, and even flags are all ints, usually defaulted to zero. Makes it easier to see which non-default value is being assigned.

This doesn't actually change execution, just cleans up the call sites to the QueryExecutor.execute(...) to use the new classes. Also, I don't think this would a breaking changed as I think the QueryExecutor and its interfaces are purely internal.

Passes tests locally though ran into a seemingly unrelated test error on travis (https://travis-ci.org/github/sehrope/pgjdbc/jobs/685079132#L718):

DatabaseMetaDataCacheTest > testGetTypeInfoUsesCache
    java.util.ConcurrentModificationException
        at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:907)
        at java.util.ArrayList$Itr.next(ArrayList.java:857)
        at org.postgresql.util.TestLogHandler.getRecordsMatching(TestLogHandler.java:32)
        at org.postgresql.test.jdbc2.DatabaseMetaDataCacheTest.testGetTypeInfoUsesCache(DatabaseMetaDataCacheTest.java:78)

Let's see if that pops up again.

[davecramer]

Curious what are you trying to solve here ?

[sehrope]

There's a couple of open PRs to add features to the executor, e.g. #1718 or #1735. Each of them adds optional parameters to the QueryExecutor.execute(...) methods. Plus there's enough existing args with the same data type (int) that it's hard to follow what exactly is being invoked. Using a separate options class helps document the existing usage and limit conflicts for future additions.

So this PR doesn't actually add or change anything. It just refactors things a bit for future PRs.

[davecramer]

Seems reasonable

[davecramer]

@sehrope can you rebase please ?

[sehrope]

Rebased. I think I might have made the checker happy too. If not I'll take another peek tonight.

[codecov-commenter]

Codecov Report

Merging #1779 into master will increase coverage by 0.13%.
The diff coverage is 88.28%.

@@             Coverage Diff              @@
##             master    #1779      +/-   ##
============================================
+ Coverage     69.26%   69.39%   +0.13%     
- Complexity     4206     4222      +16     
============================================
  Files           197      199       +2     
  Lines         17981    18098     +117     
  Branches       2914     2916       +2     
============================================
+ Hits          12455    12560     +105     
- Misses         4181     4188       +7     
- Partials       1345     1350       +5     

[sehrope]

@davecramer This should be good to go.