Binary array index

[bokken]

All Submissions:

• [ x] Have you followed the guidelines in our Contributing document?
• [x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Existing Features:

• Does this break existing behaviour? If so please explain.
  All binary array representations changing to be 1 based, which matches the string representation.
• [x ] Have you added an explanation of what your changes do and why you'd like us to include them?
• [x ] Have you written new tests for your core changes, as applicable?
• [x ] Have you successfully run tests with your changes locally?

[davecramer]

that was quick. Thanks!

[codecov-commenter]

Codecov Report

Merging #1863 into master will increase coverage by 0.02%.
The diff coverage is 90.90%.

@@             Coverage Diff              @@
##             master    #1863      +/-   ##
============================================
+ Coverage     69.21%   69.23%   +0.02%     
- Complexity     4193     4201       +8     
============================================
  Files           197      197              
  Lines         17996    17984      -12     
  Branches       2916     2914       -2     
============================================
- Hits          12456    12452       -4     
+ Misses         4188     4182       -6     
+ Partials       1352     1350       -2     

[davecramer]

Do you have time to add an entry into CHANGELOG just noting this was a regression fix

[davecramer]

are we good to push this ?

[bokken]

Looks like there is 1 more test I lost some changes in while re-basing. Hold please.

[bokken]

@davecramer the changes look good to me now.

[bokken]

@davecramer it seems like the test which is failing is flaky and unrelated to these changes:

FAILURE  10.7sec, org.postgresql.replication.PhysicalReplicationTest > restartPhysicalReplicationWithoutRepeatMessage
    java.lang.AssertionError: Interrupt physical replication and restart from lastReceiveLSN should not lead to repeat messages skip part of them
    Expected: <true>
         but: was <false>
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
        at org.postgresql.replication.PhysicalReplicationTest.restartPhysicalReplicationWithoutRepeatMessage(PhysicalReplicationTest.java:253)

[davecramer]

ya, I'm not too worried about that one. At some point someone should try to fix it, but yes it is flaky.

is this ready to go then ?

[bokken]

Ready to go.