fix:remove osgi from karaf fixes Issue #1891

[davecramer]

Currently we have no automated way to test this

[davecramer]

@steinarb can you check this works on your end. I checked it out and it was fine.

you can build it and push it to your local repo using
./gradlew publishToMavenLocal -Ppgjdbc.version=1.0.0-dev-master -PskipJavadoc

then in karaf specify 1.0.0-dev-master-SNAPSHOT as the jdbc version.

Thanks!

[steinarb]

@steinarb can you check this works on your end. I checked it out and it was fine.

you can build it and push it to your local repo using
./gradlew publishToMavenLocal -Ppgjdbc.version=1.0.0-dev-master -PskipJavadoc

then in karaf specify 1.0.0-dev-master-SNAPSHOT as the jdbc version.

Looks good!

Here's what I did:

1. Installed the feature over an ssh connection. The connection wasn't terminated

   karaf@root()> feature:repo-add mvn:org.postgresql/postgresql/1.0.0-dev-master-SNAPSHOT/xml/features
   Adding feature url mvn:org.postgresql/postgresql/1.0.0-dev-master-SNAPSHOT/xml/features
   karaf@root()> feature:install postgresql
   karaf@root()>
   

2. Used the snapshot in one of my karaf applications https://github.com/steinarb/authservice
3. Stop karaf, delete the data directory, restart karaf (to lose the already installed postgresql feature)
4. Installed authservice in karaf without any ill effects (used an ssh connection to the console here also)
5. Did a smoke test of the installed authservice (verified that I could log in and changed my first name)
6. Stopped and started karaf (without deleting or adding anything) and logged in again and verified that my first name was still changed
7. Did a manual visual check of the feature.xml file in the local maven repo and it looks good to me (just loading the transaction-api feature and the bundle itself)

So it looks good! Thanks for fixing it!