fix: send type void parameters as null value #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code sent parameters of type void (used for OUT parameters of functions) with a text value of "null". While this doesn't affect anything, since the value is ignored anyway, it's somewhat confusing, especially if it shows up in debug traces and error messages, and it's also a bit wasteful to send 4 bytes for nothing. So instead, send those parameters as a null value, which seems semantically saner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on adding support for procedure OUT parameters to the JDBC driver. More on that later. In the meantime, while I was playing around with various ideas, I noticed that the parameters of type
voidare sent to the server with a payload value of"null"as a string. This seems a bit strange and wasteful. I suggest to change this to a real null value.I looked up the original commit where this came in (ccc8f4c), but didn't see any explanation there either. Perhaps it wasn't ever questioned.
All Submissions:
Changes to Existing Features: