Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dependency on java-comment-preprocesor from postgresql-jdbc.spec.tpl #1930

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

odubaj
Copy link
Contributor

@odubaj odubaj commented Oct 15, 2020

This dependency is no longer needed for package build

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does ./gradlew autostyleCheck checkstyleAll pass ?
  3. Have you added your new test classes to an existing test suite in alphabetical order?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

This dependency is no longer needed for package build
@davecramer
Copy link
Member

There's no guarantee that we won't use it again.

@odubaj
Copy link
Contributor Author

odubaj commented Oct 15, 2020

There's no guarantee that we won't use it again.

But currently it is not used. We need to have this information for the future, as java-comment-preprocessor is currently only used by pgjdbc in Fedora. If pgjdbc won't use java-comment-preprocessor, we can orphan it.
Thanks for your reply.

@vlsi vlsi changed the title Remove dependency on java-comment-preprocesor chore: remove dependency on java-comment-preprocesor from postgresql-jdbc.spec.tpl Oct 19, 2020
@vlsi vlsi merged commit 3a271f1 into pgjdbc:master Oct 19, 2020
@odubaj
Copy link
Contributor Author

odubaj commented Oct 20, 2020

Thanks for the merge. Can I understand it as: "java-comment-preprocessor won't be used in the future anymore" ?
Thanks.

@vlsi
Copy link
Member

vlsi commented Oct 20, 2020

java-comment-preprocessor won't be used in the future anymore

nobody knows

@davecramer
Copy link
Member

if for some reason we require conditional compilation again it will be used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants