revert 4fa2d5bc1ed8 to fix the regression introduced. Fixes [Issue 2180](https://github.com/pgjdbc/pgjdbc/issues/2180) #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this happening because the "non-blocking" read to check if notifications are available is blocking? |
|
yes, this is a problem with ssl connections only. InputStream.read(...) blocks so we end up introducing a timeout on every interaction if there is nothing to read. |
|
Dang. Out of scope for an immediate fix but maybe we can save the underlying socket and check that for availability regardless of whether it's replaced with an SSL wrapped one. |
|
The real solution is to read the incoming data in a background thread. This solves many issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.