Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Parser does not handle new version 14 function definition syntax #2506

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davecramer
Copy link
Member

The npgsql folks ran into this npgsql/npgsql#4445
Apparently multi-line functions can be defined without using $$ and semicolons are legal
This provides a failing test for same
There is some discussion about providing a connection parameter to pass the provided SQL as is without rewriting it in #1946. This may solve the problem somewhat

@davecramer davecramer mentioned this pull request May 9, 2022
5 tasks
@vlsi
Copy link
Member

vlsi commented May 9, 2022

It looks like we need to parse procedure body as well (we could treat begin-end pairs as quote start and quote end)

@roji
Copy link

roji commented May 9, 2022

I'll keep an eye on this to see what you guys come up with - we may do the same in Npgsql.

Note that on our side there's also a "no-parse" option, where Npgsql just sends the SQL as-is. I'm hoping that long-term people would be able to shift to that, though realistically the SQL parsing/rewriting is likely here to stay.

@roji
Copy link

roji commented May 9, 2022

In case you guys are interested, here's a post I wrote about the no-parse mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants