Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table alias to the getUDT query for clarity #2553

Merged
merged 1 commit into from Jun 22, 2022

Conversation

alurie
Copy link
Contributor

@alurie alurie commented Jun 21, 2022

This change adds a table alias to the generated query for getUDT method, in order to make it more clear which table is being referenced.
This was done based on the feedback on initial PR (#2522)

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable? N/A (tests already exist).
  • Have you successfully run tests with your changes locally?

@davecramer davecramer merged commit 4c7a092 into pgjdbc:master Jun 22, 2022
davecramer added a commit to davecramer/pgjdbc that referenced this pull request Aug 1, 2022
davecramer added a commit that referenced this pull request Aug 3, 2022
* Revert "fix: replace syncronization in Connection.close with compareAndSet"

* Revert "feat: synchronize statement executions (e.g. avoid deadlock when Connection.isValid is executed from concurrent threads)"

* Revert "set a timeout to get the return from requesting SSL upgrade. (#2572)"

* Revert "add alias to the generated query for clarity (#2553)"
davecramer added a commit to davecramer/pgjdbc that referenced this pull request Aug 3, 2022
davecramer added a commit that referenced this pull request Aug 8, 2022
* Revert "Revert "add alias to the generated query for clarity (#2553)""

This reverts commit 6c30e48.

* Revert "Revert "set a timeout to get the return from requesting SSL upgrade. (#2572)""

This reverts commit 6b10d8d.

* Revert "Revert "feat: synchronize statement executions (e.g. avoid deadlock when Connection.isValid is executed from concurrent threads)""

This reverts commit 50cee9d.

* Revert "Revert "fix: replace syncronization in Connection.close with compareAndSet""

This reverts commit 54fa61d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants