New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split /build.gradle.kts to build-logic/ plugins #2755
Conversation
d841bb2
to
5ee11ef
Compare
49c0f27
to
fd239c4
Compare
I think this is good enough, so I will merge it shortly unless there are comments. |
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* Copyright (c) 2020, PostgreSQL Global Development Group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 2023 right?
I'm not an expert on these things, but I think you'd need to leave the original notice place and add ours under it to cover subsequent changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair point. Ya, we can't remove licenses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 2023 right?
The copyright date should be "the first date the file was introduced".
In other words, we claim the file is part of pgjdbc since 2020.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave the original notice place and add ours under it to cover subsequent changes.
The original notice was "apache 2" by mistake as it was automatically added, and I did not notice the header was wrong.
See https://docs.gradle.org/current/userguide/structuring_software_products.html