Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix testGetSQLTypeQueryCache by searching for xid type. #2805

Merged
merged 9 commits into from Feb 15, 2023

Conversation

davecramer
Copy link
Member

@davecramer davecramer commented Feb 14, 2023

We used to search for box type but it is now cached

fix OidValueCorrectnessTest BOX_ARRAY OID, by adding BOX_ARRAY to the oidTypeName map

…to search for box type but it is now cached

fix OidValueCorrectnessTest BOX_ARRAY OID, by adding BOX_ARRAY to the oidTypeName map
@davecramer
Copy link
Member Author

@vlsi do you know why this does not run the tests ?

@vlsi
Copy link
Member

vlsi commented Feb 14, 2023

I guess we need to adjust branches: '*' to branches: '**' in the workflow definition: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

Could you try that?

to ensure that all pull requests get tested
@davecramer
Copy link
Member Author

I guess we need to adjust branches: '*' to branches: '**' in the workflow definition: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

Could you try that?

that worked!

* Add copy examples
* re-add slonik duke image

* compressed
* edit changelogs to make them correct and readable
update copyright to include 2023

* Correct the instructions for building without tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants