Fix #3224 - conversion for TIME '24:00' to LocalTime breaks in binary-mode #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests which verify, that conversion of binary-transferred TIME/TIMETZ `24:00` to LocalTime currently fails
fixes conversion of TIME/TIMETZ `24:00` to LocalTime from binary. we now convert `24:00` to `LocalTime.MAX` instead of failing with `Invalid value for NanoOfDay`, which is now consistent with conversion from text.
davecramer
reviewed
Apr 22, 2024
pgjdbc/src/test/java/org/postgresql/test/jdbc42/GetObject310Test.java
Outdated
Show resolved
Hide resolved
`#setUp()` and `#tearDown()` manage the test-table's lifecycle. the test-table gets dropped at end of test anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes to Existing Features:
Description
Fixes the bug described in #3224
Conversion of binary-values of
TIMEhas been adapted to interpret24:00asLocalTime.MAX- as does conversion from text-values.As PostgreSQL only supports microsecond-precision, all values larger than
23:59:59.999_999_499are converted toLocalTime.MAX- as is done in other places in TimestampUtils.javaBinary test-values for TimestampUtilsTest.java are guessed, as I couldn't find a documentation / source, of how they're actually computed.