Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add GitHub CI testing with PostgreSQL 15 and HEAD #3257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: add GitHub CI testing with PostgreSQL 15 and HEAD #3257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ jobs:
with:
fetch-depth: 50
- name: Start PostgreSQL PGV=${{ matrix.pg_version }} TZ=${{ matrix.server_tz }} XA=${{ matrix.xa }} SSL=${{ matrix.ssl }} SCRAM=${{ matrix.scram }} CREATE_REPLICAS=${{ matrix.replication }}
working-directory: docker/postgres-server
working-directory: ${{ matrix.pg_version == 'HEAD' && 'docker/postgres-head' || 'docker/postgres-server' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of random failures building and testing against HEAD so we should ignore errors. We'll see have the details in actions to see what happened, but no point in CI randomly turning red because HEAD itself is broken.

That's what the omni action would do:

pgjdbc/.github/workflows/omni.yml

Line 374 in 450488c

continue-on-error: true

Also, we should probably disable HEAD entirely for PRs and enable it always for master and any daily runs.

env:
PGV: ${{ matrix.pg_version }}
TZ: ${{ matrix.server_tz }}
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/matrix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ matrix.addAxis({
'12',
'13',
'14',
'15',
'16',
// 'latest' will automatically pick the latest from DockerHub so we
'latest',
'HEAD',
]
});

Expand Down Expand Up @@ -233,7 +238,8 @@ matrix.generateRow({scram: {value: 'yes'}});
matrix.generateRow({java_version: eaJava});
// Ensure we have a job with the minimal and maximal PostgreSQL versions
matrix.generateRow({pg_version: matrix.axisByName.pg_version.values[0]});
matrix.generateRow({pg_version: matrix.axisByName.pg_version.values.slice(-1)[0]});
matrix.generateRow({pg_version: 'latest'});
matrix.generateRow({pg_version: 'HEAD'});
//Ensure at least one job with "simple" query_mode exists
matrix.generateRow({query_mode: {value: 'simple'}});
// Ensure there will be at least one job with minimal supported Java
Expand Down
2 changes: 2 additions & 0 deletions docker/postgres-head/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ RUN export DEBIAN_FRONTEND=noninteractive \
dumb-init \
flex \
git \
libicu-dev \
pkg-config \
libperl-dev \
libreadline-dev \
libssl-dev \
Expand Down
3 changes: 2 additions & 1 deletion docker/postgres-server/scripts/post-startup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ create_replica () {
CREATE USER ${replication_user} WITH REPLICATION PASSWORD '${replication_pass}';
SELECT * FROM pg_create_physical_replication_slot('${replication_slot_name}');
"
pg_basebackup -D "${replica_data_dir}" -S "${replication_slot_name}" -X stream -P -Fp -R
# checkpoint=fast is to prevent "checkpoint starting: force wait"
pg_basebackup --checkpoint=fast -D "${replica_data_dir}" -S "${replication_slot_name}" -X stream -P -Fp -R

cat <<EOF >>"${replica_data_dir}/postgresql.conf"
port = ${port}
Expand Down
Loading