fix: make sure {fn now()} jdbc translation is not performed in dollar-quoted strings #512

vlsi · 2016-02-10T21:07:35Z

closes #511

codecov-io · 2016-02-10T21:39:53Z

Current coverage is `57.53%`

Merging #512 into master will increase coverage by +0.02% as of d697e9d

@@            master    #512   diff @@
======================================
  Files          143     143       
  Stmts        15108   15131    +23
  Branches      2961    2966     +5
  Methods          0       0       
======================================
+ Hit           8690    8706    +16
- Partial       1170    1176     +6
- Missed        5248    5249     +1

Review entire Coverage Diff as of d697e9d

Powered by Codecov. Updated on successful CI builds.

davecramer · 2016-02-13T00:31:41Z

pgjdbc/src/test/java/org/postgresql/test/jdbc2/QuotationTest.java

+  private final String[] args;
+  private final String expected;
+
+  public QuotationTest(QuoteStyle quoteStyle, String expected, String expr, String[] args) {


why is args necessary ? It doesn't appear to be used ?

Nice catch. Initially I thought to use it as "bind arguments", then it turned out to be unused.

…-quoted strings closes pgjdbc#511

vlsi force-pushed the dollar_quotes branch from 7e34053 to 162821a Compare February 10, 2016 21:27

davecramer reviewed Feb 13, 2016
View reviewed changes

fix: make sure {fn now()} jdbc translation is not performed in dollar…

9109451

…-quoted strings closes pgjdbc#511

vlsi force-pushed the dollar_quotes branch from 162821a to 9109451 Compare February 13, 2016 13:47

vlsi merged commit 9109451 into pgjdbc:master Feb 18, 2016

vlsi deleted the dollar_quotes branch February 19, 2016 08:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: make sure {fn now()} jdbc translation is not performed in dollar-quoted strings #512

fix: make sure {fn now()} jdbc translation is not performed in dollar-quoted strings #512

vlsi commented Feb 10, 2016

codecov-io commented Feb 10, 2016

davecramer Feb 13, 2016

vlsi Feb 13, 2016

fix: make sure {fn now()} jdbc translation is not performed in dollar-quoted strings #512

fix: make sure {fn now()} jdbc translation is not performed in dollar-quoted strings #512

Conversation

vlsi commented Feb 10, 2016

codecov-io commented Feb 10, 2016

Current coverage is 57.53%

davecramer Feb 13, 2016

Choose a reason for hiding this comment

vlsi Feb 13, 2016

Choose a reason for hiding this comment

Current coverage is `57.53%`