Consider search_path when looking up type OIDs in TypeInfoCache #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case when types with the same name existed in several schemas, TypeInfoCache did not consider the current search_path and was choosing an OID of a type not deterministically. These change will make the type from the current schema to be chosen. Also this change remains backwards compatible with the previous implementation, still being anble to find a type, that is not included into the current search_path. Provided test fails now, as it does not TypeInfoCache directly. So more work is to be done to make this test work.
|
Is there any chance to get at least some feedback on this request :( |
|
I had sent an email regarding your other patch for prepared statements. I did not hear a response, I presumed you didn't care ? |
|
Oh Lord, I suppose I missed something :( What email? I have to search for your email to me. I hope it is not in spam... |
davecramer
pushed a commit
that referenced
this pull request
Jun 10, 2013
Consider search_path when looking up type OIDs in TypeInfoCache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case when types with the same name existed in several schemas,
TypeInfoCache did not consider the current search_path and was choosing
an OID of a type not deterministically. These change will make
the type from the current schema to be chosen. Also this change remains
backwards compatible with the previous implementation, still being anble
to find a type, that is not included into the current search_path.
Though the fix changes the behavior of TypeInfoCache, MetaData logic
still does not consider search_path, when reflecting database objects.