Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support PostgreSQL 9.6 #560

Merged
merged 1 commit into from May 14, 2016
Merged

fix: support PostgreSQL 9.6 #560

merged 1 commit into from May 14, 2016

Conversation

vlsi
Copy link
Member

@vlsi vlsi commented May 14, 2016

This PR adds PostgreSQL 9.6 regression test.

org.postgresql.jdbc.PgDatabaseMetaData#getIndexInfo is changed to return NULL AS ASC_OR_DESC for 9.6+.

9.6 does not have pg_am.amcanorder, thus getIndexInfo failed as the following:

testPartialIndexInfo(org.postgresql.test.jdbc2.DatabaseMetaDataTest)  Time elapsed: 0.055 sec  <<< ERROR!
org.postgresql.util.PSQLException: ERROR: column am.amcanorder does not exist
  Position: 427
    at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2299)
    at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2015)
    at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:210)
    at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:425)
    at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:322)
    at org.postgresql.jdbc.PgStatement.executeQuery(PgStatement.java:285)
    at org.postgresql.jdbc.PgDatabaseMetaData.getIndexInfo(PgDatabaseMetaData.java:2952)
    at org.postgresql.test.jdbc2.DatabaseMetaDataTest.testPartialIndexInfo(DatabaseMetaDataTest.java:605)

@codecov-io
Copy link

codecov-io commented May 14, 2016

Current coverage is 70.47%

Merging #560 into master will increase coverage by +<.01%

  1. 2 files (not in diff) in ...a/org/postgresql/ssl were modified. more
    • Misses -3
  2. 6 files (not in diff) in .../org/postgresql/jdbc were modified. more
    • Misses +1
    • Hits -2
  3. 2 files (not in diff) in .../org/postgresql/core were modified. more
@@             master       #560   diff @@
==========================================
  Files           146        146          
  Lines         15497      15495     -2   
  Methods           0          0          
  Messages          0          0          
  Branches       3062       3055     -7   
==========================================
  Hits          10920      10920          
+ Misses         4577       4575     -2   
  Partials          0          0          

Powered by Codecov. Last updated by dc3bdda...e675c66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants