New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate to Junit4 #738
Closed
Closed
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4eb90f5
refactor: migrate to Junit4
AlexElin f37579d
refactor: migrate to Junit4
AlexElin afd1ab6
refactor: migrate to Junit4
AlexElin 4aa53b7
refactor: migrate to Junit4
AlexElin 423980a
Merge remote-tracking branch 'upstream/master' into migrate_to_junit4
AlexElin 708db4c
refactor: migrate to Junit4
AlexElin fb8bbe3
refactor: migrate to Junit4
AlexElin 40fdd18
refactor: migrate to Junit4
AlexElin d6ac3d2
refactor: migrate to Junit4
AlexElin e5ce771
refactor: migrate to Junit4
AlexElin 0e3b47a
Merge branch 'master' into migrate_to_junit4
AlexElin 85f9c7c
refactor: migrate to Junit4
AlexElin e8cd79a
Merge branch 'master' into migrate_to_junit4
AlexElin 7e4dd77
refactor: migrate to Junit4
AlexElin a4ae6af
refactor: migrate to Junit4
AlexElin 7a956d0
refactor: migrate to Junit4
AlexElin c5cd6d7
refactor: migrate to Junit4
AlexElin 53a5b14
Revert refactor: migrate to Junit4
AlexElin b640294
refactor: migrate to Junit4
AlexElin 46532d7
Merge branch 'master' into migrate_to_junit4
AlexElin 806d5c5
Merge branch 'master' into migrate_to_junit4
AlexElin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do GetObject310Test and GetObject310BinaryTest work after your changes?
Previously GetObject310Test was powered by
extends BaseTest
, and now you seem to convert it to JUnit4 format.That means updateProperties will never be called. Will it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be called.
I removed the GetObject310BinaryTest and made the GetObject310Test as parameterized.