Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to Junit4 #738

Closed
wants to merge 21 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -9,10 +9,6 @@

public class GetObject310BinaryTest extends GetObject310Test {

public GetObject310BinaryTest(String name) {
super(name);
}

@Override
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do GetObject310Test and GetObject310BinaryTest work after your changes?

Previously GetObject310Test was powered by extends BaseTest, and now you seem to convert it to JUnit4 format.
That means updateProperties will never be called. Will it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be called.

I removed the GetObject310BinaryTest and made the GetObject310Test as parameterized.

protected void updateProperties(Properties props) {
forceBinary(props);
Expand Down