Fix #92, missing NonValidatingFactory in JDBC3 driver

[ringerc]

See #92

You need this patch if attempts to use a URL like

jdbc:postgresql://ipaddress:port/dbname?ssl=true&sslfactory=org.postgresql.ssl.NonValidatingFactory

fails with:

java.lang.ClassNotFoundException: org.postgresql.ssl.NonValidatingFactory

in the stack trace.

[ringerc]

This problem was introduced in rev b295ebd:

$ git diff  b295ebd1 b295ebd1~1 build.xml`
...
@@ -170,8 +170,8 @@
        <exclude name="${package}/jdcb4/Jdbc4*.java" unless="jdbc4any" />

        <!-- ssl -->
-       <include name="${package}/ssl/jdbc4/*.java" if="jdbc4any"/>
-       <include name="${package}/ssl/jdbc3/*.java" if="jdbc3any"/>
+       <include name="${package}/ssl/*.java" if="jdbc4any"/>
+       <exclude name="${package}/ssl/*.java" unless="jdbc4any"/>

        <!-- gss -->
        <include name="${package}/gss/*.java" />

It was then duplicated in rev 48abd5a along with a whole pile of other build code. The purpose of the duplication isn't clear to me as the commit message reads only "for maven"; maybe we should revisit that and see if there's a way to avoid duplicating it all?

[lordnelson]

@ringerc I had removed the duplication in #54 as the same pattern was required for building a Maven source jar as well as the main compile task. If that gets merged it should reduce the duplication (but I need to refresh my PR to include this bug fix.)

[davecramer]

@lordnelson can you redo #54 so it will merge please ? I need to make pushing to maven more automated

[lordnelson]

Sure @davecramer, I'll do it in the next couple of days.

[ringerc]

That is handy. I think one of the lines is "/.java" where it should be "/*.java" though; I only noticed after as it didn't affect testing and output.

Stephen Nelson notifications@github.com wrote:

@ringerc I had removed the duplication in #54 as the same pattern was required for building a Maven source jar as well as the main compile task. If that gets merged it should reduce the duplication (but I need to refresh my PR to include this bug fix.)

—
Reply to this email directly or view it on GitHub.